summaryrefslogtreecommitdiff
path: root/CONTRIBUTING.md
diff options
context:
space:
mode:
authorjvoisin2017-10-01 21:46:02 +0200
committerjvoisin2017-10-01 21:46:02 +0200
commit7418a0e1e9b02aef8535e33d30cfb8f082680f69 (patch)
tree28caaf2ecc25a5e2d4104ac7552176d9cf81c5d3 /CONTRIBUTING.md
parentb5628fcc599919711171a5154f37ad90bd6b5065 (diff)
Fix some typos (courtesy of @sabban) and mention tests in the CONTRIBUTING.md file
Diffstat (limited to 'CONTRIBUTING.md')
-rw-r--r--CONTRIBUTING.md6
1 files changed, 3 insertions, 3 deletions
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
index acf7220..623d4ba 100644
--- a/CONTRIBUTING.md
+++ b/CONTRIBUTING.md
@@ -6,7 +6,7 @@ First off, thank you for considering contributing to snuffleupagus.
6 6
7If you've noticed a bug or have a question, 7If you've noticed a bug or have a question,
8look at the [faq](https://snuffleupagus.readthedocs.io/faq.html) and 8look at the [faq](https://snuffleupagus.readthedocs.io/faq.html) and
9[search the issue tracker](https://github.com/nbs-system/snuffleupagus/issues) 9[search the issue tracker](https://github.com/nbs-system/snuffleupagus/issues)
10to see if someone else has already created a ticket. If not, go ahead and 10to see if someone else has already created a ticket. If not, go ahead and
11[make one](https://github.com/nbs-system/snuffleupagus/issues/new)! 11[make one](https://github.com/nbs-system/snuffleupagus/issues/new)!
12 12
@@ -25,7 +25,7 @@ git checkout -b 325-kill-sql-injections
25### 3. Get the test suite running 25### 3. Get the test suite running
26 26
27Just type `make coverage` or `make debug`, the testsuite should be run 27Just type `make coverage` or `make debug`, the testsuite should be run
28automatically. 28automatically. Please do add tests if you're fixing a bug or adding a new feature.
29 29
30### 4. Did you find a bug? 30### 4. Did you find a bug?
31 31
@@ -70,7 +70,7 @@ Finally, go to GitHub and [make a Pull Request](https://help.github.com/articles
70Travis CI will run our test suite against all supported PHP versions. We care 70Travis CI will run our test suite against all supported PHP versions. We care
71about quality, so your PR won't be merged until all tests pass. It's unlikely, 71about quality, so your PR won't be merged until all tests pass. It's unlikely,
72but it's possible that your changes pass tests in one PHP version but fail in 72but it's possible that your changes pass tests in one PHP version but fail in
73another. In that case, you'll have to setup your development environment 73another. In that case, you'll have to setup your development environment
74to use the problematic PHP version, and investigate 74to use the problematic PHP version, and investigate
75what's going on! 75what's going on!
76 76