From 7418a0e1e9b02aef8535e33d30cfb8f082680f69 Mon Sep 17 00:00:00 2001 From: jvoisin Date: Sun, 1 Oct 2017 21:46:02 +0200 Subject: Fix some typos (courtesy of @sabban) and mention tests in the CONTRIBUTING.md file --- CONTRIBUTING.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'CONTRIBUTING.md') diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index acf7220..623d4ba 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -6,7 +6,7 @@ First off, thank you for considering contributing to snuffleupagus. If you've noticed a bug or have a question, look at the [faq](https://snuffleupagus.readthedocs.io/faq.html) and -[search the issue tracker](https://github.com/nbs-system/snuffleupagus/issues) +[search the issue tracker](https://github.com/nbs-system/snuffleupagus/issues) to see if someone else has already created a ticket. If not, go ahead and [make one](https://github.com/nbs-system/snuffleupagus/issues/new)! @@ -25,7 +25,7 @@ git checkout -b 325-kill-sql-injections ### 3. Get the test suite running Just type `make coverage` or `make debug`, the testsuite should be run -automatically. +automatically. Please do add tests if you're fixing a bug or adding a new feature. ### 4. Did you find a bug? @@ -70,7 +70,7 @@ Finally, go to GitHub and [make a Pull Request](https://help.github.com/articles Travis CI will run our test suite against all supported PHP versions. We care about quality, so your PR won't be merged until all tests pass. It's unlikely, but it's possible that your changes pass tests in one PHP version but fail in -another. In that case, you'll have to setup your development environment +another. In that case, you'll have to setup your development environment to use the problematic PHP version, and investigate what's going on! -- cgit v1.3