summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorjvoisin2018-07-18 16:22:39 +0200
committerjvoisin2018-07-18 16:22:39 +0200
commit087faeef01dcf94188a7c2f1015e3aed83a6a20b (patch)
tree4f52db63e8a18b147fd6f1197bf9c5ae9a3506ed
parentca21a749469b46ccafce86faca1092a93a21c8c6 (diff)
Improve a bit our release process
-rw-r--r--CONTRIBUTING.md14
1 files changed, 7 insertions, 7 deletions
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
index 9a31fd4..0a6a408 100644
--- a/CONTRIBUTING.md
+++ b/CONTRIBUTING.md
@@ -120,19 +120,18 @@ Any maintainer is allowed to merge a PR if all of these conditions are met.
120Maintainers need to do the following to push out a release: 120Maintainers need to do the following to push out a release:
121 121
1221. Make sure that all pending and mergeable pull requests are in 1221. Make sure that all pending and mergeable pull requests are in
1232. Close the corresponding
124 [milestone](https://github.com/nbs-system/snuffleupagus/milestones)
1232. Run `valgrind` (by adding a `-m` after the `-q` in the Makefile) and check that everything is ok. 1252. Run `valgrind` (by adding a `-m` after the `-q` in the Makefile) and check that everything is ok.
124 Don't mind the python-related issues. 126 Don't mind the python-related issues.
1253. Update the `src/php_snuffleupagus.h` file: drop the `-dev` suffix and check new version comply with [semantic versioning](https://semver.org/) 1273. Update the `src/php_snuffleupagus.h` according to [semantic versioning](https://semver.org/)
1264. Update the changelog page in the documentation 1284. Update the changelog page in the documentation
1275. Update the Debian changelog in `./debian/changelog` with `dch` 1295. Update the Debian changelog in `./debian/changelog` with `cd debian; dch`
1286. Commit the result 1306. Commit the result
1297. Clean up the folder `make clean; git clean -xdf` 1317. Clean up the folder `make clean; git clean -xdf`
1308. Create a tag for the release: 1328. Create a tag for the release:
131 133
132 ```sh 134 ```sh
133 git checkout master
134 git pull origin master
135 make coverage
136 git config user.signingkey 498C46FF087EDC36E7EAF9D445414A82A9B22D78 135 git config user.signingkey 498C46FF087EDC36E7EAF9D445414A82A9B22D78
137 git config user.email security@nbs-system.com 136 git config user.email security@nbs-system.com
138 git tag -s v$MAJOR.$MINOR.$PATCH -m "v$MAJOR.$MINOR.$PATCH" 137 git tag -s v$MAJOR.$MINOR.$PATCH -m "v$MAJOR.$MINOR.$PATCH"
@@ -141,5 +140,6 @@ Maintainers need to do the following to push out a release:
141 140
1429. Build the debian package with `make debian` 1419. Build the debian package with `make debian`
14310. Create the [release on github](https://github.com/nbs-system/snuffleupagus/releases) 14210. Create the [release on github](https://github.com/nbs-system/snuffleupagus/releases)
14411. Update the `src/php_snuffleupagus.h` file: bump the version 3rd digit and add the `-dev` suffix 14311. Add the freshly built Debian package to the release
14512. Do the *secret release dance* 14412. Publish a [tweet](https://twitter.com/sp_php)
14513. Do the *secret release dance*