diff options
Diffstat (limited to 'CONTRIBUTING.md')
| -rw-r--r-- | CONTRIBUTING.md | 14 |
1 files changed, 7 insertions, 7 deletions
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 9a31fd4..0a6a408 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md | |||
| @@ -120,19 +120,18 @@ Any maintainer is allowed to merge a PR if all of these conditions are met. | |||
| 120 | Maintainers need to do the following to push out a release: | 120 | Maintainers need to do the following to push out a release: |
| 121 | 121 | ||
| 122 | 1. Make sure that all pending and mergeable pull requests are in | 122 | 1. Make sure that all pending and mergeable pull requests are in |
| 123 | 2. Close the corresponding | ||
| 124 | [milestone](https://github.com/nbs-system/snuffleupagus/milestones) | ||
| 123 | 2. Run `valgrind` (by adding a `-m` after the `-q` in the Makefile) and check that everything is ok. | 125 | 2. Run `valgrind` (by adding a `-m` after the `-q` in the Makefile) and check that everything is ok. |
| 124 | Don't mind the python-related issues. | 126 | Don't mind the python-related issues. |
| 125 | 3. Update the `src/php_snuffleupagus.h` file: drop the `-dev` suffix and check new version comply with [semantic versioning](https://semver.org/) | 127 | 3. Update the `src/php_snuffleupagus.h` according to [semantic versioning](https://semver.org/) |
| 126 | 4. Update the changelog page in the documentation | 128 | 4. Update the changelog page in the documentation |
| 127 | 5. Update the Debian changelog in `./debian/changelog` with `dch` | 129 | 5. Update the Debian changelog in `./debian/changelog` with `cd debian; dch` |
| 128 | 6. Commit the result | 130 | 6. Commit the result |
| 129 | 7. Clean up the folder `make clean; git clean -xdf` | 131 | 7. Clean up the folder `make clean; git clean -xdf` |
| 130 | 8. Create a tag for the release: | 132 | 8. Create a tag for the release: |
| 131 | 133 | ||
| 132 | ```sh | 134 | ```sh |
| 133 | git checkout master | ||
| 134 | git pull origin master | ||
| 135 | make coverage | ||
| 136 | git config user.signingkey 498C46FF087EDC36E7EAF9D445414A82A9B22D78 | 135 | git config user.signingkey 498C46FF087EDC36E7EAF9D445414A82A9B22D78 |
| 137 | git config user.email security@nbs-system.com | 136 | git config user.email security@nbs-system.com |
| 138 | git tag -s v$MAJOR.$MINOR.$PATCH -m "v$MAJOR.$MINOR.$PATCH" | 137 | git tag -s v$MAJOR.$MINOR.$PATCH -m "v$MAJOR.$MINOR.$PATCH" |
| @@ -141,5 +140,6 @@ Maintainers need to do the following to push out a release: | |||
| 141 | 140 | ||
| 142 | 9. Build the debian package with `make debian` | 141 | 9. Build the debian package with `make debian` |
| 143 | 10. Create the [release on github](https://github.com/nbs-system/snuffleupagus/releases) | 142 | 10. Create the [release on github](https://github.com/nbs-system/snuffleupagus/releases) |
| 144 | 11. Update the `src/php_snuffleupagus.h` file: bump the version 3rd digit and add the `-dev` suffix | 143 | 11. Add the freshly built Debian package to the release |
| 145 | 12. Do the *secret release dance* | 144 | 12. Publish a [tweet](https://twitter.com/sp_php) |
| 145 | 13. Do the *secret release dance* | ||
