diff options
| author | jvoisin | 2017-10-27 16:06:39 +0200 |
|---|---|---|
| committer | jvoisin | 2017-10-27 16:06:39 +0200 |
| commit | 70498a7cce831049b47051813b850665c5547927 (patch) | |
| tree | ea1030022662e3a5d6d710660790e909516155fc /src | |
| parent | fa40064f0851b988478b283be4663ade1cf7f7e0 (diff) | |
Improve a bit the coverage wrt. broken configurations
Diffstat (limited to 'src')
| -rw-r--r-- | src/sp_config_utils.c | 4 | ||||
| -rw-r--r-- | src/tests/broken_conf_truncated.phpt | 9 | ||||
| -rw-r--r-- | src/tests/config/config_broken_conf_truncated.ini | 1 |
3 files changed, 12 insertions, 2 deletions
diff --git a/src/sp_config_utils.c b/src/sp_config_utils.c index 62fb7c1..12df098 100644 --- a/src/sp_config_utils.c +++ b/src/sp_config_utils.c | |||
| @@ -60,7 +60,7 @@ static char *get_string(size_t *consumed, char *restrict line, | |||
| 60 | size_t j = 0; | 60 | size_t j = 0; |
| 61 | 61 | ||
| 62 | char *ret = NULL; | 62 | char *ret = NULL; |
| 63 | if (NULL == line) { | 63 | if (NULL == line || '\0' == *line) { |
| 64 | goto err; | 64 | goto err; |
| 65 | } | 65 | } |
| 66 | 66 | ||
| @@ -189,4 +189,4 @@ zend_always_inline sp_node_t *parse_functions_list(char *value) { | |||
| 189 | free(tmp); | 189 | free(tmp); |
| 190 | 190 | ||
| 191 | return list; | 191 | return list; |
| 192 | } \ No newline at end of file | 192 | } |
diff --git a/src/tests/broken_conf_truncated.phpt b/src/tests/broken_conf_truncated.phpt new file mode 100644 index 0000000..74f3524 --- /dev/null +++ b/src/tests/broken_conf_truncated.phpt | |||
| @@ -0,0 +1,9 @@ | |||
| 1 | --TEST-- | ||
| 2 | Bad boolean value in configuration | ||
| 3 | --SKIPIF-- | ||
| 4 | <?php if (!extension_loaded("snuffleupagus")) print "skip"; ?> | ||
| 5 | --INI-- | ||
| 6 | sp.configuration_file={PWD}/config/config_broken_conf_truncated.ini | ||
| 7 | --FILE-- | ||
| 8 | --EXPECT-- | ||
| 9 | [snuffleupagus][0.0.0.0][error][error] A valid string as parameter is expected on line 1. | ||
diff --git a/src/tests/config/config_broken_conf_truncated.ini b/src/tests/config/config_broken_conf_truncated.ini new file mode 100644 index 0000000..bf05dfb --- /dev/null +++ b/src/tests/config/config_broken_conf_truncated.ini | |||
| @@ -0,0 +1 @@ | |||
| sp.disable_function.function("").param(no quote, omg! | |||
