Merge branch 'master' of https://github.com/jvoisin/snuffleupagus

26 files changed, 231 insertions, 109 deletions

diff --git a/src/php_snuffleupagus.h b/src/php_snuffleupagus.h
index 248045c..5b2b414 100644
--- a/src/php_snuffleupagus.h
+++ b/src/php_snuffleupagus.h
@@ -56,7 +56,7 @@ typedef void (*zif_handler)(INTERNAL_FUNCTION_PARAMETERS);
 #define TSRMLS_FETCH()
 #define TSRMLS_C
 #else
-#if ( !HAVE_PCRE && !HAVE_BUNDLED_PCRE )
+#if (!HAVE_PCRE && !HAVE_BUNDLED_PCRE)
 #error Snuffleupagus requires PHP7+ with PCRE support
 #endif
 #endif
diff --git a/src/snuffleupagus.c b/src/snuffleupagus.c
index 9a5ac90..7bf3649 100644
--- a/src/snuffleupagus.c
+++ b/src/snuffleupagus.c
@@ -21,7 +21,7 @@ ZEND_DLEXPORT int sp_zend_startup(zend_extension *extension) {
 }
 // LCOV_EXCL_END
 
-static inline void sp_op_array_handler(zend_op_array *op) {
+static inline void sp_op_array_handler(zend_op_array *const op) {
   // We need a filename, and strict mode not already enabled on this op
   if (NULL == op->filename || op->fn_flags & ZEND_ACC_STRICT_TYPES) {
     return;
@@ -47,8 +47,7 @@ static PHP_INI_MH(StrictMode) {
 PHP_INI_BEGIN()
 PHP_INI_ENTRY("sp.configuration_file", "", PHP_INI_SYSTEM,
               OnUpdateConfiguration)
-PHP_INI_ENTRY("sp.allow_broken_configuration", "0", PHP_INI_SYSTEM,
-              StrictMode)
+PHP_INI_ENTRY("sp.allow_broken_configuration", "0", PHP_INI_SYSTEM, StrictMode)
 PHP_INI_END()
 
 ZEND_DLEXPORT zend_extension zend_extension_entry = {
@@ -59,24 +58,24 @@ ZEND_DLEXPORT zend_extension zend_extension_entry = {
     PHP_SNUFFLEUPAGUS_COPYRIGHT,
     sp_zend_startup,
     NULL,
-    NULL,                 /* activate_func_t */
-    NULL,                 /* deactivate_func_t */
-    NULL,                 /* message_handler_func_t */
-    sp_op_array_handler,  /* op_array_handler_func_t */
-    NULL,                 /* statement_handler_func_t */
-    NULL,                 /* fcall_begin_handler_func_t */
-    NULL,                 /* fcall_end_handler_func_t */
-    NULL,                 /* op_array_ctor_func_t */
-    NULL,                 /* op_array_dtor_func_t */
+    NULL,                /* activate_func_t */
+    NULL,                /* deactivate_func_t */
+    NULL,                /* message_handler_func_t */
+    sp_op_array_handler, /* op_array_handler_func_t */
+    NULL,                /* statement_handler_func_t */
+    NULL,                /* fcall_begin_handler_func_t */
+    NULL,                /* fcall_end_handler_func_t */
+    NULL,                /* op_array_ctor_func_t */
+    NULL,                /* op_array_dtor_func_t */
     STANDARD_ZEND_EXTENSION_PROPERTIES};
 
 PHP_GINIT_FUNCTION(snuffleupagus) {
   snuffleupagus_globals->is_config_valid = SP_CONFIG_NONE;
   snuffleupagus_globals->in_eval = 0;
 
-#define SP_INIT_HT(F) snuffleupagus_globals->F = \
-    pemalloc(sizeof(*(snuffleupagus_globals->F)), 1); \
-    zend_hash_init(snuffleupagus_globals->F, 10, NULL, NULL, 1);
+#define SP_INIT_HT(F)                                                          \
+  snuffleupagus_globals->F = pemalloc(sizeof(*(snuffleupagus_globals->F)), 1); \
+  zend_hash_init(snuffleupagus_globals->F, 10, NULL, NULL, 1);
   SP_INIT_HT(disabled_functions_hook);
   SP_INIT_HT(sp_internal_functions_hook);
   SP_INIT_HT(sp_eval_blacklist_functions_hook);
@@ -86,8 +85,9 @@ PHP_GINIT_FUNCTION(snuffleupagus) {
   SP_INIT_HT(config.config_disabled_functions_ret_hooked);
 #undef SP_INIT_HT
 
-#define SP_INIT(F) snuffleupagus_globals->config.F = \
-    pecalloc(sizeof(*(snuffleupagus_globals->config.F)), 1, 1);
+#define SP_INIT(F)                  \
+  snuffleupagus_globals->config.F = \
+      pecalloc(sizeof(*(snuffleupagus_globals->config.F)), 1, 1);
   SP_INIT(config_unserialize);
   SP_INIT(config_random);
   SP_INIT(config_sloppy);
@@ -121,23 +121,22 @@ PHP_MINIT_FUNCTION(snuffleupagus) {
   return SUCCESS;
 }
 
-static void free_disabled_functions_hashtable(HashTable *ht) {
+static void free_disabled_functions_hashtable(HashTable *const ht) {
   void *ptr = NULL;
   ZEND_HASH_FOREACH_PTR(ht, ptr) { sp_list_free(ptr); }
   ZEND_HASH_FOREACH_END();
 }
 
 PHP_MSHUTDOWN_FUNCTION(snuffleupagus) {
-
 #define FREE_HT(F)                       \
-      zend_hash_destroy(SNUFFLEUPAGUS_G(F)); \
-      pefree(SNUFFLEUPAGUS_G(F), 1);
+  zend_hash_destroy(SNUFFLEUPAGUS_G(F)); \
+  pefree(SNUFFLEUPAGUS_G(F), 1);
   FREE_HT(disabled_functions_hook);
   FREE_HT(sp_eval_blacklist_functions_hook);
 
-#define FREE_HT_LIST(F) \
-      free_disabled_functions_hashtable(SNUFFLEUPAGUS_G(config).F); \
-      FREE_HT(config.F);
+#define FREE_HT_LIST(F)                                         \
+  free_disabled_functions_hashtable(SNUFFLEUPAGUS_G(config).F); \
+  FREE_HT(config.F);
   FREE_HT_LIST(config_disabled_functions);
   FREE_HT_LIST(config_disabled_functions_hooked);
   FREE_HT_LIST(config_disabled_functions_ret);
@@ -145,18 +144,21 @@ PHP_MSHUTDOWN_FUNCTION(snuffleupagus) {
 #undef FREE_HT_LIST
 #undef FREE_HT
 
-#define FREE_LST_DISABLE(L)                \
-    do {                                     \
-      sp_list_node *_n = SNUFFLEUPAGUS_G(config).L; \
-      sp_disabled_function_list_free(_n);    \
-      sp_list_free(_n);                      \
-    } while (0)
+#define FREE_LST_DISABLE(L)                       \
+  do {                                            \
+    sp_list_node *_n = SNUFFLEUPAGUS_G(config).L; \
+    sp_disabled_function_list_free(_n);           \
+    sp_list_free(_n);                             \
+  } while (0)
   FREE_LST_DISABLE(config_disabled_functions_reg->disabled_functions);
   FREE_LST_DISABLE(config_disabled_functions_reg_ret->disabled_functions);
 #undef FREE_LST_DISABLE
 
+  sp_list_node *_n = SNUFFLEUPAGUS_G(config).config_cookie->cookies;
+  sp_cookie_list_free(_n);
+  sp_list_free(_n);
+
 #define FREE_LST(L) sp_list_free(SNUFFLEUPAGUS_G(config).L);
-  FREE_LST(config_cookie->cookies);
   FREE_LST(config_eval->blacklist);
   FREE_LST(config_eval->whitelist);
   FREE_LST(config_wrapper->whitelist);
@@ -184,24 +186,26 @@ PHP_MSHUTDOWN_FUNCTION(snuffleupagus) {
 }
 
 PHP_RINIT_FUNCTION(snuffleupagus) {
-  const sp_config_wrapper* config_wrapper =
+  const sp_config_wrapper *const config_wrapper =
       SNUFFLEUPAGUS_G(config).config_wrapper;
 #if defined(COMPILE_DL_SNUFFLEUPAGUS) && defined(ZTS)
   ZEND_TSRMLS_CACHE_UPDATE();
 #endif
 
   if (!SNUFFLEUPAGUS_G(allow_broken_configuration)) {
-    if (SNUFFLEUPAGUS_G(is_config_valid) == SP_CONFIG_INVALID ) {
+    if (SNUFFLEUPAGUS_G(is_config_valid) == SP_CONFIG_INVALID) {
       sp_log_err("config", "Invalid configuration file");
     } else if (SNUFFLEUPAGUS_G(is_config_valid) == SP_CONFIG_NONE) {
-      sp_log_warn("config", "No configuration specificed via sp.configuration_file");
+      sp_log_warn("config",
+                  "No configuration specificed via sp.configuration_file");
     }
   }
 
-  // We need to disable wrappers loaded by extensions loaded after SNUFFLEUPAGUS.
+  // We need to disable wrappers loaded by extensions loaded after
+  // SNUFFLEUPAGUS.
   if (config_wrapper->enabled &&
       zend_hash_num_elements(php_stream_get_url_stream_wrappers_hash()) !=
-      config_wrapper->num_wrapper) {
+          config_wrapper->num_wrapper) {
     sp_disable_wrapper();
   }
 
@@ -218,7 +222,7 @@ PHP_RSHUTDOWN_FUNCTION(snuffleupagus) { return SUCCESS; }
 
 PHP_MINFO_FUNCTION(snuffleupagus) {
   const char *valid_config;
-  switch(SNUFFLEUPAGUS_G(is_config_valid)) {
+  switch (SNUFFLEUPAGUS_G(is_config_valid)) {
     case SP_CONFIG_VALID:
       valid_config = "yes";
       break;
@@ -230,10 +234,11 @@ PHP_MINFO_FUNCTION(snuffleupagus) {
       valid_config = "no";
   }
   php_info_print_table_start();
-  php_info_print_table_row(2, "snuffleupagus support",
-      SNUFFLEUPAGUS_G(is_config_valid)?"enabled":"disabled");
+  php_info_print_table_row(
+      2, "snuffleupagus support",
+      SNUFFLEUPAGUS_G(is_config_valid) ? "enabled" : "disabled");
   php_info_print_table_row(2, "Version", PHP_SNUFFLEUPAGUS_VERSION);
-  php_info_print_table_row( 2, "Valid config", valid_config);
+  php_info_print_table_row(2, "Valid config", valid_config);
   php_info_print_table_end();
   DISPLAY_INI_ENTRIES();
 }
@@ -245,14 +250,15 @@ static PHP_INI_MH(OnUpdateConfiguration) {
     return FAILURE;
   }
 
-  glob_t globbuf;
-  char *config_file;
-  char *rest = new_value->val;
+  char *str = new_value->val;
 
-  while ((config_file = strtok_r(rest, ",", &rest))) {
-    int ret = glob(config_file, GLOB_NOCHECK, NULL, &globbuf);
+  while (1) {
+    // We don't care about overwriting new_value->val
+    const char *config_file = strsep(&str, ",");
+    if (config_file == NULL) break;
 
-    if (ret != 0) {
+    glob_t globbuf;
+    if (0 != glob(config_file, GLOB_NOCHECK, NULL, &globbuf)) {
       SNUFFLEUPAGUS_G(is_config_valid) = SP_CONFIG_INVALID;
       globfree(&globbuf);
       return FAILURE;
@@ -315,11 +321,12 @@ static PHP_INI_MH(OnUpdateConfiguration) {
 
   // If `zend_write_default` is not NULL it is already hooked.
   if ((zend_hash_str_find(
-          SNUFFLEUPAGUS_G(config).config_disabled_functions_hooked, "echo",
-          sizeof("echo") - 1) ||
-      zend_hash_str_find(
-          SNUFFLEUPAGUS_G(config).config_disabled_functions_ret_hooked, "echo",
-          sizeof("echo") - 1)) && NULL == zend_write_default) {
+           SNUFFLEUPAGUS_G(config).config_disabled_functions_hooked, "echo",
+           sizeof("echo") - 1) ||
+       zend_hash_str_find(
+           SNUFFLEUPAGUS_G(config).config_disabled_functions_ret_hooked, "echo",
+           sizeof("echo") - 1)) &&
+      NULL == zend_write_default && zend_write != hook_echo) {
     zend_write_default = zend_write;
     zend_write = hook_echo;
   }
diff --git a/src/sp_config.c b/src/sp_config.c
index 69730e3..c12b435 100644
--- a/src/sp_config.c
+++ b/src/sp_config.c
@@ -6,7 +6,7 @@
 
 size_t sp_line_no;
 
-sp_config_tokens const sp_func[] = {
+static sp_config_tokens const sp_func[] = {
     {.func = parse_unserialize, .token = SP_TOKEN_UNSERIALIZE_HMAC},
     {.func = parse_random, .token = SP_TOKEN_HARDEN_RANDOM},
     {.func = parse_log_media, .token = SP_TOKEN_LOG_MEDIA},
@@ -73,7 +73,11 @@ int parse_list(char *restrict line, char *restrict keyword, void *list_ptr) {
   }
 
   tmp = ZSTR_VAL(value);
-  while ((token = strtok_r(tmp, ",", &tmp))) {
+  while (1) {
+    token = strsep(&tmp, ",");
+    if (token == NULL) {
+      break;
+    }
     *list = sp_list_insert(*list, zend_string_init(token, strlen(token), 1));
   }
 
@@ -216,11 +220,32 @@ void sp_disabled_function_list_free(sp_list_node *list) {
   sp_list_node *cursor = list;
   while (cursor) {
     sp_disabled_function *df = cursor->data;
-    if (df && df->functions_list) sp_list_free(df->functions_list);
     if (df) {
+      sp_list_free(df->functions_list);
+      sp_list_free(df->param_array_keys);
+      sp_list_free(df->var_array_keys);
+
+      sp_pcre_free(df->r_filename);
+      sp_pcre_free(df->r_function);
+      sp_pcre_free(df->r_param);
+      sp_pcre_free(df->r_ret);
+      sp_pcre_free(df->r_value);
+      sp_pcre_free(df->r_key);
+
       sp_tree_free(df->param);
       sp_tree_free(df->var);
     }
     cursor = cursor->next;
   }
 }
+
+void sp_cookie_list_free(sp_list_node *list) {
+  sp_list_node *cursor = list;
+  while (cursor) {
+    sp_cookie *c = cursor->data;
+    if (c) {
+      sp_pcre_free(c->name_r);
+    }
+    cursor = cursor->next;
+  }
+}
diff --git a/src/sp_config.h b/src/sp_config.h
index b06e8be..e7b1473 100644
--- a/src/sp_config.h
+++ b/src/sp_config.h
@@ -282,5 +282,6 @@ int parse_list(char *restrict, char *restrict, void *);
 
 // cleanup
 void sp_disabled_function_list_free(sp_list_node *);
+void sp_cookie_list_free(sp_list_node *);
 
 #endif /* SP_CONFIG_H */
diff --git a/src/sp_disable_xxe.c b/src/sp_disable_xxe.c
index 113d84b..f9712b5 100644
--- a/src/sp_disable_xxe.c
+++ b/src/sp_disable_xxe.c
@@ -1,26 +1,41 @@
 #include "php_snuffleupagus.h"
 
-PHP_FUNCTION(sp_libxml_disable_entity_loader) { RETURN_TRUE; }
+PHP_FUNCTION(sp_libxml_disable_entity_loader) {
+  sp_log_warn("xxe",
+              "A call to libxml_disable_entity_loader was tried and nopped");
+  RETURN_TRUE;
+}
+
+PHP_FUNCTION(sp_libxml_set_external_entity_loader) {
+  sp_log_warn(
+      "xxe",
+      "A call to libxml_set_external_entity_loader was tried and nopped");
+  RETURN_TRUE;
+}
 
 int hook_libxml_disable_entity_loader() {
   TSRMLS_FETCH();
 
-// External entities are disabled by default in PHP8+
-#if PHP_VERSION_ID < 80000
-  /* Call the php function here instead of re-implementing it is a bit
-   * ugly, but we do not want to introduce compile-time dependencies against
-   * libxml. */
   zval func_name;
-  zval hmac;
+  zval retval;
   zval params[1];
 
+#if PHP_VERSION_ID < 80000
+  // This function is deprecated in PHP8, but better safe than sorry for php7.
   ZVAL_STRING(&func_name, "libxml_disable_entity_loader");
   ZVAL_STRING(&params[0], "true");
-  call_user_function(CG(function_table), NULL, &func_name, &hmac, 1, params);
+  call_user_function(CG(function_table), NULL, &func_name, &retval, 1, params);
 #endif
 
+  // This is now the recommended way to disable external entities
+  ZVAL_STRING(&func_name, "libxml_set_external_entity_loader");
+  ZVAL_NULL(&params[0]);
+  call_user_function(CG(function_table), NULL, &func_name, &retval, 1, params);
+
   HOOK_FUNCTION("libxml_disable_entity_loader", sp_internal_functions_hook,
                 PHP_FN(sp_libxml_disable_entity_loader));
+  HOOK_FUNCTION("libxml_set_external_entity_loader", sp_internal_functions_hook,
+                PHP_FN(sp_libxml_set_external_entity_loader));
 
   return SUCCESS;
 }
diff --git a/src/sp_execute.c b/src/sp_execute.c
index de83a2a..7d078b0 100644
--- a/src/sp_execute.c
+++ b/src/sp_execute.c
@@ -274,17 +274,23 @@ int hook_execute(void) {
   TSRMLS_FETCH();
 
   if (NULL == orig_execute_ex && NULL == orig_zend_stream_open) {
-    /* zend_execute_ex is used for "user" function calls */
-    orig_execute_ex = zend_execute_ex;
-    zend_execute_ex = sp_execute_ex;
+    if (zend_execute_ex != sp_execute_ex) {
+      /* zend_execute_ex is used for "user" function calls */
+      orig_execute_ex = zend_execute_ex;
+      zend_execute_ex = sp_execute_ex;
+    }
 
-    /* zend_execute_internal is used for "builtin" functions calls */
-    orig_zend_execute_internal = zend_execute_internal;
-    zend_execute_internal = sp_zend_execute_internal;
+    if (zend_execute_internal != sp_zend_execute_internal) {
+      /* zend_execute_internal is used for "builtin" functions calls */
+      orig_zend_execute_internal = zend_execute_internal;
+      zend_execute_internal = sp_zend_execute_internal;
+    }
 
-    /* zend_stream_open_function is used for include-related stuff */
-    orig_zend_stream_open = zend_stream_open_function;
-    zend_stream_open_function = sp_stream_open;
+    if (zend_stream_open_function != sp_stream_open) {
+      /* zend_stream_open_function is used for include-related stuff */
+      orig_zend_stream_open = zend_stream_open_function;
+      zend_stream_open_function = sp_stream_open;
+    }
   }
 
   return SUCCESS;
diff --git a/src/sp_pcre_compat.c b/src/sp_pcre_compat.c
index 509a8ea..3bd00ca 100644
--- a/src/sp_pcre_compat.c
+++ b/src/sp_pcre_compat.c
@@ -1,5 +1,12 @@
 #include "php_snuffleupagus.h"
 
+inline void sp_pcre_free(sp_pcre* regexp) {
+#ifdef SP_HAS_PCRE2
+  pcre2_code_free(regexp);
+#endif
+  regexp = NULL;
+}
+
 sp_pcre* sp_pcre_compile(const char* const pattern) {
   assert(NULL != pattern);
 
@@ -34,7 +41,11 @@ bool ZEND_HOT sp_is_regexp_matching_len(const sp_pcre* regexp, const char* str,
 #ifdef SP_HAS_PCRE2
   pcre2_match_data* match_data =
       pcre2_match_data_create_from_pattern(regexp, NULL);
+  if (NULL == match_data) {
+    sp_log_err("regexp", "Unable to get memory for a regxp.");
+  }
   ret = pcre2_match(regexp, (PCRE2_SPTR)str, len, 0, 0, match_data, NULL);
+  pcre2_match_data_free(match_data);
 #else
   int vec[30];
   ret = pcre_exec(regexp, NULL, str, len, 0, 0, vec, sizeof(vec) / sizeof(int));
diff --git a/src/sp_pcre_compat.h b/src/sp_pcre_compat.h
index 14c33b2..725004d 100644
--- a/src/sp_pcre_compat.h
+++ b/src/sp_pcre_compat.h
@@ -17,6 +17,7 @@
 #endif
 
 sp_pcre* sp_pcre_compile(const char* str);
+void sp_pcre_free(sp_pcre* regexp);
 #define sp_is_regexp_matching_zend(regexp, zstr) \
   sp_is_regexp_matching_len(regexp, ZSTR_VAL(zstr), ZSTR_LEN(zstr))
 #define sp_is_regexp_matching(regexp, str) \
diff --git a/src/sp_sloppy.c b/src/sp_sloppy.c
index f9ed718..ff2d644 100644
--- a/src/sp_sloppy.c
+++ b/src/sp_sloppy.c
@@ -99,12 +99,13 @@ PHP_FUNCTION(sp_array_keys) {
 void hook_sloppy() {
   TSRMLS_FETCH();
 
-  if (NULL == orig_zend_compile_file) {
+  if (NULL == orig_zend_compile_file && zend_compile_file != sp_compile_file) {
     orig_zend_compile_file = zend_compile_file;
     zend_compile_file = sp_compile_file;
   }
 
-  if (NULL == orig_zend_compile_string) {
+  if (NULL == orig_zend_compile_string &&
+      zend_compile_string != sp_compile_string) {
     orig_zend_compile_string = zend_compile_string;
     zend_compile_string = sp_compile_string;
   }
diff --git a/src/sp_upload_validation.c b/src/sp_upload_validation.c
index f3ae311..cebab3e 100644
--- a/src/sp_upload_validation.c
+++ b/src/sp_upload_validation.c
@@ -103,6 +103,10 @@ int sp_rfc1867_callback(unsigned int event, void *event_data, void **extra) {
 #endif
 
 void hook_upload() {
+  if (php_rfc1867_callback == sp_rfc1867_callback) {
+    return;
+  }
+
   if (NULL == sp_rfc1867_orig_callback) {
     sp_rfc1867_orig_callback = php_rfc1867_callback;
     php_rfc1867_callback = sp_rfc1867_callback;
diff --git a/src/sp_utils.c b/src/sp_utils.c
index 73c0546..5f25920 100644
--- a/src/sp_utils.c
+++ b/src/sp_utils.c
@@ -19,24 +19,6 @@ const char* get_ipaddr() {
     return fwd_ip;
   }
 
-  /* Some hosters (like heroku, see
-   * https://github.com/jvoisin/snuffleupagus/issues/336) are clearing the
-   * environment variables, so we don't have access to them, hence why we're
-   * resorting to $_SERVER['REMOTE_ADDR'].
-   */
-  if (!Z_ISUNDEF(PG(http_globals)[TRACK_VARS_SERVER])) {
-    const zval* const globals_client_ip =
-        zend_hash_str_find(Z_ARRVAL(PG(http_globals)[TRACK_VARS_SERVER]),
-                           "REMOTE_ADDR", sizeof("REMOTE_ADDR") - 1);
-    if (globals_client_ip) {
-      if (Z_TYPE_P(globals_client_ip) == IS_STRING) {
-        if (Z_STRLEN_P(globals_client_ip) != 0) {
-          return estrdup(Z_STRVAL_P(globals_client_ip));
-        }
-      }
-    }
-  }
-
   return default_ipaddr;
 }
 
diff --git a/src/sp_var_parser.c b/src/sp_var_parser.c
index b066b84..bb5a5c0 100644
--- a/src/sp_var_parser.c
+++ b/src/sp_var_parser.c
@@ -20,7 +20,7 @@ static sp_list_node *parse_str_tokens(const char *str,
   return tokens_list;
 }
 
-static bool is_var_name_valid(const char *name) {
+static bool is_var_name_valid(const char *const name) {
   static sp_pcre *regexp_const = NULL;
   static sp_pcre *regexp_var = NULL;
 
diff --git a/src/sp_var_value.c b/src/sp_var_value.c
index b9ac357..fe37f99 100644
--- a/src/sp_var_value.c
+++ b/src/sp_var_value.c
@@ -1,6 +1,7 @@
 #include "php_snuffleupagus.h"
 
-static zval *get_param_var(zend_execute_data *ed, const char *var_name) {
+static zval *get_param_var(const zend_execute_data *const ed,
+                           const char *const var_name, bool print) {
   unsigned int nb_param = ed->func->common.num_args;
 
   for (unsigned int i = 0; i < nb_param; i++) {
@@ -13,11 +14,14 @@ static zval *get_param_var(zend_execute_data *ed, const char *var_name) {
     if (0 == strcmp(arg_name, var_name)) {
       return ZEND_CALL_VAR_NUM(ed, i);
     }
+    if (print == true) {
+      sp_log_warn("config", "  - %d parameter's name: '%s'", i, arg_name);
+    }
   }
   return NULL;
 }
 
-static zval *get_local_var(zend_execute_data *ed, const char *var_name) {
+static zval *get_local_var(zend_execute_data *ed, const char *const var_name) {
   zend_execute_data *orig_execute_data = ed;
   zend_execute_data *current = ed;
 
@@ -48,7 +52,7 @@ static zval *get_local_var(zend_execute_data *ed, const char *var_name) {
   return NULL;
 }
 
-static zval *get_constant(const char *value) {
+static zval *get_constant(const char *const value) {
   zend_string *name = zend_string_init(value, strlen(value), 0);
   zval *zvalue = zend_get_constant_ex(name, NULL, ZEND_FETCH_CLASS_SILENT);
   zend_string_release(name);
@@ -68,7 +72,7 @@ static zval *get_var_value(zend_execute_data *ed, const char *var_name,
   }
 
   if (is_param) {
-    zval *zvalue = get_param_var(ed, var_name);
+    zval *zvalue = get_param_var(ed, var_name, false);
     if (!zvalue) {
       char *complete_function_path = get_complete_function_path(ed);
       sp_log_warn("config",
@@ -76,6 +80,7 @@ static zval *get_var_value(zend_execute_data *ed, const char *var_name,
                   "'%s' of the function '%s', but the parameter does "
                   "not exists.",
                   var_name, complete_function_path);
+      get_param_var(ed, var_name, true);
       efree(complete_function_path);
       return NULL;
     }
@@ -85,8 +90,8 @@ static zval *get_var_value(zend_execute_data *ed, const char *var_name,
   }
 }
 
-static void *get_entry_hashtable(const HashTable *ht, const char *entry,
-                                 size_t entry_len) {
+static void *get_entry_hashtable(const HashTable *const ht,
+                                 const char *const entry, size_t entry_len) {
   zval *zvalue = zend_hash_str_find(ht, entry, entry_len);
 
   if (!zvalue) {
@@ -104,8 +109,8 @@ static void *get_entry_hashtable(const HashTable *ht, const char *entry,
   return zvalue;
 }
 
-static zval *get_array_value(zend_execute_data *ed, zval *zvalue,
-                             const sp_tree *tree) {
+static zval *get_array_value(zend_execute_data *ed, const zval *const zvalue,
+                             const sp_tree *const tree) {
   zval *idx_value = sp_get_var_value(ed, tree->idx, false);
 
   if (!zvalue || !idx_value) {
@@ -113,7 +118,7 @@ static zval *get_array_value(zend_execute_data *ed, zval *zvalue,
   }
 
   if (Z_TYPE_P(zvalue) == IS_ARRAY) {
-    const zend_string *idx = sp_zval_to_zend_string(idx_value);
+    const zend_string *const idx = sp_zval_to_zend_string(idx_value);
     return get_entry_hashtable(Z_ARRVAL_P(zvalue), ZSTR_VAL(idx),
                                ZSTR_LEN(idx));
   }
@@ -123,10 +128,10 @@ static zval *get_array_value(zend_execute_data *ed, zval *zvalue,
 
 static zval *get_object_property(zend_execute_data *ed, zval *object,
                                  const char *property, bool is_param) {
-  char *class_name = object->value.obj->ce->name->val;
+  const char *const class_name = object->value.obj->ce->name->val;
   HashTable *array = Z_OBJPROP_P(object);
   zval *zvalue = NULL;
-  zval *property_val = get_var_value(ed, property, is_param);
+  const zval *property_val = get_var_value(ed, property, is_param);
   size_t len;
 
   if (property_val) {
@@ -156,7 +161,7 @@ static zval *get_object_property(zend_execute_data *ed, zval *object,
   return zvalue;
 }
 
-static zend_class_entry *get_class(const char *value) {
+static zend_class_entry *get_class(const char *const value) {
   zend_string *name = zend_string_init(value, strlen(value), 0);
   zend_class_entry *ce = zend_lookup_class(name);
   zend_string_release(name);
@@ -165,7 +170,7 @@ static zend_class_entry *get_class(const char *value) {
 
 static zval *get_unknown_type(const char *restrict value, zval *zvalue,
                               zend_class_entry *ce, zend_execute_data *ed,
-                              const sp_tree *tree, bool is_param) {
+                              const sp_tree *const tree, bool is_param) {
   if (ce) {
     zvalue = get_entry_hashtable(&ce->constants_table, value, strlen(value));
     ce = NULL;
diff --git a/src/sp_wrapper.c b/src/sp_wrapper.c
index 277f23a..7610114 100644
--- a/src/sp_wrapper.c
+++ b/src/sp_wrapper.c
@@ -1,6 +1,6 @@
 #include "php_snuffleupagus.h"
 
-static bool wrapper_is_whitelisted(const zend_string *zs) {
+static bool wrapper_is_whitelisted(const zend_string *const zs) {
   const sp_list_node *list = SNUFFLEUPAGUS_G(config).config_wrapper->whitelist;
 
   if (!zs) {
@@ -18,7 +18,7 @@ static bool wrapper_is_whitelisted(const zend_string *zs) {
 
 void sp_disable_wrapper() {
   HashTable *orig = php_stream_get_url_stream_wrappers_hash();
-  HashTable *orig_complete = pemalloc(sizeof(*orig_complete), 1);
+  HashTable *orig_complete = pemalloc(sizeof(HashTable), 1);
   zval *zv;
   zend_string *zs;
 
diff --git a/src/tests/broken_configuration/broken_conf_config_invalid_param.phpt b/src/tests/broken_configuration/broken_conf_config_invalid_param.phpt
index ac85dea..45ccf24 100644
--- a/src/tests/broken_configuration/broken_conf_config_invalid_param.phpt
+++ b/src/tests/broken_configuration/broken_conf_config_invalid_param.phpt
@@ -13,4 +13,10 @@ function foo($blah, $x = null, $y = null) {
 foo("qwe");
 --EXPECTF--
 Warning: [snuffleupagus][0.0.0.0][config][log] It seems that you are filtering on a parameter 'qwe' of the function 'foo', but the parameter does not exists. in %s/tests/broken_configuration/broken_conf_config_invalid_param.php on line %d
+
+Warning: [snuffleupagus][0.0.0.0][config][log]   - 0 parameter's name: 'blah' in %s/tests/broken_configuration/broken_conf_config_invalid_param.php on line %d
+
+Warning: [snuffleupagus][0.0.0.0][config][log]   - 1 parameter's name: 'x' in %s/tests/broken_configuration/broken_conf_config_invalid_param.php on line %d
+
+Warning: [snuffleupagus][0.0.0.0][config][log]   - 2 parameter's name: 'y' in %s/tests/broken_configuration/broken_conf_config_invalid_param.php on line %d
 ok
diff --git a/src/tests/broken_configuration_php8/broken_conf_session_encryption_without_encryption_key.phpt b/src/tests/broken_configuration_php8/broken_conf_session_encryption_without_encryption_key.phpt
index 046dc7d..62ee41e 100644
--- a/src/tests/broken_configuration_php8/broken_conf_session_encryption_without_encryption_key.phpt
+++ b/src/tests/broken_configuration_php8/broken_conf_session_encryption_without_encryption_key.phpt
@@ -6,6 +6,7 @@ Broken configuration - encrypted session without encryption key
 --INI--
 sp.configuration_file={PWD}/config/broken_conf_session_encryption_without_encryption_key.ini
 --FILE--
+--XFAIL--
 --EXPECT--
 
 Fatal error: [snuffleupagus][0.0.0.0][config][log] You're trying to use the session cookie encryption feature on line 2 without having set the `.secret_key` option in`sp.global`: please set it first in Unknown on line 0
diff --git a/src/tests/broken_configuration_php8/broken_conf_session_encryption_without_env_var.phpt b/src/tests/broken_configuration_php8/broken_conf_session_encryption_without_env_var.phpt
index bb0f212..5acc1cd 100644
--- a/src/tests/broken_configuration_php8/broken_conf_session_encryption_without_env_var.phpt
+++ b/src/tests/broken_configuration_php8/broken_conf_session_encryption_without_env_var.phpt
@@ -6,6 +6,7 @@ Broken configuration - encrypted session without env var
 --INI--
 sp.configuration_file={PWD}/config/broken_conf_session_encryption_without_env_var.ini
 --FILE--
+--XFAIL--
 --EXPECT--
 
 Fatal error: [snuffleupagus][0.0.0.0][config][log] You're trying to use the session cookie encryption feature on line 2 without having set the `.cookie_env_var` option in`sp.global`: please set it first in Unknown on line 0
diff --git a/src/tests/deny_writable/deny_writable_execution_simulation.phpt b/src/tests/deny_writable/deny_writable_execution_simulation.phpt
index 30f8cb1..d4b8efc 100644
--- a/src/tests/deny_writable/deny_writable_execution_simulation.phpt
+++ b/src/tests/deny_writable/deny_writable_execution_simulation.phpt
@@ -3,7 +3,7 @@ Readonly execution attempt (simulation mode)
 --SKIPIF--
 <?php if (PHP_VERSION_ID >= 80000) print "skip"; ?>
 <?php
-if (!extension_loaded("snuffleupagus")) { print "skip" };
+if (!extension_loaded("snuffleupagus")) { print "skip"; };
 
 // root has write privileges on any file
 if (TRUE == function_exists("posix_getuid")) {
diff --git a/src/tests/disable_function/config/disabled_functions.ini b/src/tests/disable_function/config/disabled_functions.ini
index df7013f..0758c98 100644
--- a/src/tests/disable_function/config/disabled_functions.ini
+++ b/src/tests/disable_function/config/disabled_functions.ini
@@ -7,3 +7,4 @@ sp.disable_function.function_r("^var_dump$").drop();
 sp.disable_function.function("sprintf").filename("/wrong file name").drop();
 sp.disable_function.function("sprintf").filename("/wrong file name").drop();
 sp.disable_function.function("eval").drop();
+sp.disable_function.function("shell_exec").param("foo").value("bar").drop();
diff --git a/src/tests/disable_function/config/disabled_functions_chmod.ini b/src/tests/disable_function/config/disabled_functions_chmod.ini
new file mode 100644
index 0000000..e601900
--- /dev/null
+++ b/src/tests/disable_function/config/disabled_functions_chmod.ini
@@ -0,0 +1,4 @@
+# PHP7 and below
+sp.disable_function.function("chmod").param("mode").value("511").drop();
+# PHP8
+sp.disable_function.function("chmod").param("permissions").value("511").drop();
diff --git a/src/tests/disable_function/disabled_functions_chmod.phpt b/src/tests/disable_function/disabled_functions_chmod.phpt
new file mode 100644
index 0000000..28f948d
--- /dev/null
+++ b/src/tests/disable_function/disabled_functions_chmod.phpt
@@ -0,0 +1,14 @@
+--TEST--
+Disable functions - chmod
+--SKIPIF--
+<?php if (!extension_loaded("snuffleupagus")) print "skip"; ?>
+<?php if (PHP_VERSION_ID >= 80000) print "skip"; ?>
+--INI--
+sp.configuration_file={PWD}/config/disabled_functions_chmod.ini
+--FILE--
+<?php
+chmod( 'foo', 0777 );
+?>
+--XFAIL--
+--EXPECTF--
+Fatal error: [snuffleupagus][0.0.0.0][disabled_function][drop] Aborted execution on call of the function 'chmod', because its argument '$mode' content (511) matched a rule in %a/disabled_function_chmod.php on line %d
diff --git a/src/tests/disable_function/disabled_functions_chmod_php8.phpt b/src/tests/disable_function/disabled_functions_chmod_php8.phpt
new file mode 100644
index 0000000..71bb034
--- /dev/null
+++ b/src/tests/disable_function/disabled_functions_chmod_php8.phpt
@@ -0,0 +1,14 @@
+--TEST--
+Disable functions - chmod, in php8
+--SKIPIF--
+<?php if (!extension_loaded("snuffleupagus")) print "skip"; ?>
+<?php if (PHP_VERSION_ID < 80000) print "skip"; ?>
+--INI--
+sp.configuration_file={PWD}/config/disabled_functions_chmod.ini
+--FILE--
+<?php
+chmod( 'foo', 0777 );
+?>
+--XFAIL--
+--EXPECTF--
+Fatal error: [snuffleupagus][0.0.0.0][disabled_function][drop] Aborted execution on call of the function 'chmod', because its argument '$permissions' content (511) matched a rule in %a/disabled_function_chmod_php8.php on line %d
diff --git a/src/tests/disable_function/disabled_functions_shell_exec_wrong.phpt b/src/tests/disable_function/disabled_functions_shell_exec_wrong.phpt
new file mode 100644
index 0000000..fe8e73a
--- /dev/null
+++ b/src/tests/disable_function/disabled_functions_shell_exec_wrong.phpt
@@ -0,0 +1,14 @@
+--TEST--
+Disable functions - shell_exec, with a non-existing command
+--SKIPIF--
+<?php if (!extension_loaded("snuffleupagus")) print "skip"; ?>
+--INI--
+sp.configuration_file={PWD}/config/disabled_functions.ini
+--FILE--
+<?php 
+$gs = exec( 'foo' );
+echo "YES";
+?>
+--EXPECTF--
+%snot found
+YES
diff --git a/src/tests/session_encryption/crypt_session_corrupted_session.phpt b/src/tests/session_encryption/crypt_session_corrupted_session.phpt
index a89faf4..a97dbca 100644
--- a/src/tests/session_encryption/crypt_session_corrupted_session.phpt
+++ b/src/tests/session_encryption/crypt_session_corrupted_session.phpt
@@ -2,6 +2,8 @@
 Set a custom session handler
 --SKIPIF--
 <?php if (!extension_loaded("snuffleupagus")) print "skip"; ?>
+<?php if (PHP_VERSION_ID >= 80000) print "skip"; ?>
+<?php if (PHP_VERSION_ID >= 70400) print "skip"; ?>
 --INI--
 sp.configuration_file={PWD}/config/config_crypt_session.ini
 session.save_path = "/tmp"
diff --git a/src/tests/session_encryption/crypt_session_invalid.phpt b/src/tests/session_encryption/crypt_session_invalid.phpt
index 9ec7c50..967d9d1 100644
--- a/src/tests/session_encryption/crypt_session_invalid.phpt
+++ b/src/tests/session_encryption/crypt_session_invalid.phpt
@@ -2,6 +2,8 @@
 SESSION crypt and bad decrypt
 --SKIPIF--
 <?php if (!extension_loaded("snuffleupagus")) print "skip"; ?>
+<?php if (PHP_VERSION_ID >= 80000) print "skip"; ?>
+<?php if (PHP_VERSION_ID >= 70400) print "skip"; ?>
 --INI--
 sp.configuration_file={PWD}/config/config_crypt_session.ini
 --ENV--
diff --git a/src/tests/xxe/disable_xxe_dom_disabled.phpt b/src/tests/xxe/disable_xxe_dom_disabled.phpt
index 493f5a3..a49e094 100644
--- a/src/tests/xxe/disable_xxe_dom_disabled.phpt
+++ b/src/tests/xxe/disable_xxe_dom_disabled.phpt
@@ -44,8 +44,13 @@ printf("without xxe: %s", $dom->getElementsByTagName('testing')->item(0)->nodeVa
 
 ?>
 --EXPECTF-- 
+Warning: [snuffleupagus][0.0.0.0][xxe][log] A call to libxml_disable_entity_loader was tried and nopped in %s/tests/xxe/disable_xxe_dom_disabled.php on line %d
 libxml_disable_entity to true: WARNING, external entity loaded!
+
+Warning: [snuffleupagus][0.0.0.0][xxe][log] A call to libxml_disable_entity_loader was tried and nopped in %s/tests/xxe/disable_xxe_dom_disabled.php on line %d
 libxml_disable_entity to false: WARNING, external entity loaded!
+
+Warning: [snuffleupagus][0.0.0.0][xxe][log] A call to libxml_disable_entity_loader was tried and nopped in %s/tests/xxe/disable_xxe_dom_disabled.php on line %d
 without xxe: foo
 --CLEAN--
 <?php