diff options
| author | jvoisin | 2017-10-30 17:13:35 +0100 |
|---|---|---|
| committer | jvoisin | 2017-10-30 17:13:35 +0100 |
| commit | 040a5c222aa79dd25fcdf284b27109983e7578af (patch) | |
| tree | 3d027e7752089170019286afc52fb658680d161d /src | |
| parent | 0c77d1dcd817bd159682344d186e920cd8c9c150 (diff) | |
Fix a silly TOCTOU to make coverity happy
Diffstat (limited to 'src')
| -rw-r--r-- | src/sp_utils.c | 8 |
1 files changed, 3 insertions, 5 deletions
diff --git a/src/sp_utils.c b/src/sp_utils.c index 1ba0fe7..1435f3f 100644 --- a/src/sp_utils.c +++ b/src/sp_utils.c | |||
| @@ -86,11 +86,9 @@ static int construct_filename(char* filename, const char* folder) { | |||
| 86 | struct timeval tval; | 86 | struct timeval tval; |
| 87 | struct stat st = {0}; | 87 | struct stat st = {0}; |
| 88 | 88 | ||
| 89 | if (-1 == stat(folder, &st)) { | 89 | if (0 > mkdir(folder, 0700) && errno != EEXIST) { |
| 90 | if (0 != mkdir(folder, 0700)) { | 90 | sp_log_err("request_logging", "Unable to create the folder '%s'.", |
| 91 | sp_log_err("request_logging", "Unable to create the folder '%s'.", | 91 | folder); |
| 92 | folder); | ||
| 93 | } | ||
| 94 | } | 92 | } |
| 95 | 93 | ||
| 96 | memcpy(filename, folder, strlen(folder)); | 94 | memcpy(filename, folder, strlen(folder)); |
