Bump a bit the coverage

* `setcookie` doesn't always return `true` anymore
* clang-format
* Cookies with invalid decryption are dropped, but the request isn't anymore
* faulty unserialize are now dumpable

1 files changed, 7 insertions, 13 deletions

diff --git a/src/sp_config_keywords.c b/src/sp_config_keywords.c
index 6bb7130..04a3f41 100644
--- a/src/sp_config_keywords.c
+++ b/src/sp_config_keywords.c
@@ -52,12 +52,11 @@ int parse_session(char *line) {
       return -1;
     } else if (0 ==
                (SNUFFLEUPAGUS_G(config).config_snuffleupagus->encryption_key)) {
-      sp_log_err(
-          "config",
-          "You're trying to use the session cookie encryption feature "
-          "on line %zu without having set the `.encryption_key` option in"
-          "`sp.global`: please set it first",
-          sp_line_no);
+      sp_log_err("config",
+                 "You're trying to use the session cookie encryption feature "
+                 "on line %zu without having set the `.secret_key` option in"
+                 "`sp.global`: please set it first",
+                 sp_line_no);
       pefree(session, 0);
       return -1;
     }
@@ -166,7 +165,6 @@ int parse_global(char *line) {
 }
 
 static int parse_eval_filter_conf(char *line, sp_list_node **list) {
-  zend_string *rest = NULL;
   sp_config_eval *eval = SNUFFLEUPAGUS_G(config).config_eval;
 
   sp_config_functions sp_config_funcs[] = {
@@ -183,9 +181,6 @@ static int parse_eval_filter_conf(char *line, sp_list_node **list) {
     return ret;
   }
 
-  if (rest != NULL) {
-    pefree(rest, 1);
-  }
   return SUCCESS;
 }
 
@@ -286,8 +281,7 @@ int parse_cookie(char *line) {
       return -1;
     }
   }
-  SNUFFLEUPAGUS_G(config)
-      .config_cookie->cookies =
+  SNUFFLEUPAGUS_G(config).config_cookie->cookies =
       sp_list_insert(SNUFFLEUPAGUS_G(config).config_cookie->cookies, cookie);
   return SUCCESS;
 }
@@ -350,7 +344,7 @@ int parse_disabled_functions(char *line) {
   if (X && Y) {                                                          \
     sp_log_err("config",                                                 \
                "Invalid configuration line: 'sp.disabled_functions%s': " \
-               "'.%s' and '.%s' are mutually exclusive on line %zu",    \
+               "'.%s' and '.%s' are mutually exclusive on line %zu",     \
                line, STR1, STR2, sp_line_no);                            \
     return 1;                                                            \
   }