diff options
| author | jvoisin | 2026-05-01 00:36:32 +0200 |
|---|---|---|
| committer | jvoisin | 2026-05-01 00:44:53 +0200 |
| commit | ddd22b2f533db9c0da0bb262fbafa51f67c8587e (patch) | |
| tree | d319dab03de20929f95ccf7f9bec8c428ab6a66b /tests/test_strncat_dynamic_write.c | |
| parent | d6105aba5fd791e8d3f069e771517cdb947b5604 (diff) | |
Fix strncat/wcsncat
Previously, no checks were done when __n <= __b, but strncat _appends_ after
existing content, making this a overly broad check check. For example, with an
8-byte buffer containing "12345\0", strncat(buf, "ABCD", 4) would have the
check skipped, but the result "12345ABCD\0" is 10 bytes, resulting in an
overflow.
This commit fixes this oversight, and adds a bunch of tests.
Diffstat (limited to 'tests/test_strncat_dynamic_write.c')
| -rw-r--r-- | tests/test_strncat_dynamic_write.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/tests/test_strncat_dynamic_write.c b/tests/test_strncat_dynamic_write.c index d5c5a94..c538339 100644 --- a/tests/test_strncat_dynamic_write.c +++ b/tests/test_strncat_dynamic_write.c | |||
| @@ -7,11 +7,9 @@ int main(int argc, char** argv) { | |||
| 7 | strncat(buffer, "1234567", 5); | 7 | strncat(buffer, "1234567", 5); |
| 8 | puts(buffer); | 8 | puts(buffer); |
| 9 | 9 | ||
| 10 | #if 0 | ||
| 11 | CHK_FAIL_START | 10 | CHK_FAIL_START |
| 12 | strncat(buffer, argv[1], argc); | 11 | strncat(buffer, argv[1], argc); |
| 13 | CHK_FAIL_END | 12 | CHK_FAIL_END |
| 14 | #endif | ||
| 15 | 13 | ||
| 16 | puts(buffer); | 14 | puts(buffer); |
| 17 | return ret; | 15 | return ret; |
