From a1675cd79b0df2478026573b0fac52464ef3c1b7 Mon Sep 17 00:00:00 2001
From: xXx-caillou-xXx
Date: Wed, 20 Dec 2017 16:08:18 +0100
Subject: Make `setcookie` return true

We forgot to set a return value to the setcookie function, thus always returning false. Since very few frameworks/developers are checking the return value, it went unnoticed until we played with Magento, who effectively checks the return value.---
 src/tests/samesite_cookies.phpt | 16 ++++++++++++----
 1 file changed, 12 insertions(+), 4 deletions(-)

(limited to 'src/tests')

diff --git a/src/tests/samesite_cookies.phpt b/src/tests/samesite_cookies.phpt
index 12f3d72..fe74172 100644
--- a/src/tests/samesite_cookies.phpt
+++ b/src/tests/samesite_cookies.phpt
@@ -14,10 +14,18 @@ HTTPS=1
 EOF;
 --FILE--
 <?php
-setcookie("super_cookie", "super_value");
-setcookie("awful_cookie", "awful_value");
-setcookie("not_encrypted", "test_value", 1, "1", "1", false, true);
-setcookie("nice_cookie", "nice_value", 1, "1", "1", true, true);
+if (!setcookie("super_cookie", "super_value")) {
+  echo "setcookie failed.\n";
+}
+if (!setcookie("awful_cookie", "awful_value")) {
+  echo "setcookie failed.\n";
+}
+if (!setcookie("not_encrypted", "test_value", 1, "1", "1", false, true)) {
+  echo "setcookie failed.\n";
+}
+if (!setcookie("nice_cookie", "nice_value", 1, "1", "1", true, true)) {
+  echo "setcookie failed.\n";
+}
 
 $expected = array(
     'Set-Cookie: super_cookie=super_value; path=; samesite=Lax',
-- 
cgit v1.3