From d03c3c8d01f6f507bf844fec07477f30e3db61d9 Mon Sep 17 00:00:00 2001 From: jvoisin Date: Sat, 23 Feb 2019 12:06:51 +0100 Subject: Fix the testsuite on php8. In php8, it's non-trivial to hook strlen, since this function is usually optimized away by the compiler. --- src/tests/dump_request/config/dump_eval_blacklist.ini | 2 +- src/tests/dump_request/dump_eval_blacklist.phpt | 10 +++++----- 2 files changed, 6 insertions(+), 6 deletions(-) (limited to 'src/tests/dump_request') diff --git a/src/tests/dump_request/config/dump_eval_blacklist.ini b/src/tests/dump_request/config/dump_eval_blacklist.ini index 503143a..52e0202 100644 --- a/src/tests/dump_request/config/dump_eval_blacklist.ini +++ b/src/tests/dump_request/config/dump_eval_blacklist.ini @@ -1 +1 @@ -sp.eval_blacklist.list("strlen").dump("/tmp/dump_result/").simulation(); +sp.eval_blacklist.list("strtoupper").dump("/tmp/dump_result/").simulation(); diff --git a/src/tests/dump_request/dump_eval_blacklist.phpt b/src/tests/dump_request/dump_eval_blacklist.phpt index a28f34b..459a584 100644 --- a/src/tests/dump_request/dump_eval_blacklist.phpt +++ b/src/tests/dump_request/dump_eval_blacklist.phpt @@ -19,9 +19,9 @@ foreach (glob("/tmp/dump_result/sp_dump.*") as $dump) { @unlink($dump); } -$a = strlen("1337 1337 1337"); +$a = strtoupper("1337 1337 1337"); echo "Outside of eval: $a\n"; -eval('$a = strlen("1234");'); +eval('$a = strtoupper("1234");'); echo "After eval: $a\n"; $filename = glob('/tmp/dump_result/sp_dump.*')[0]; $res = file($filename); @@ -34,7 +34,7 @@ if ($res[2] != "GET:get_a='data_get_a' get_b='data_get_b' \n") { } ?> --EXPECTF-- -Outside of eval: 14 +Outside of eval: 1337 1337 1337 -Warning: [snuffleupagus][eval] A call to strlen was tried in eval, in %a/dump_eval_blacklist.php:1, logging it. in %a/dump_eval_blacklist.php(9) : eval()'d code on line 1 -After eval: 4 +Warning: [snuffleupagus][eval] A call to strtoupper was tried in eval, in %a/dump_eval_blacklist.php:1, logging it. in %a/dump_eval_blacklist.php(9) : eval()'d code on line 1 +After eval: 1234 -- cgit v1.3