From 2c4b2798e5351cff462b195c318ee7f5f18cfb5a Mon Sep 17 00:00:00 2001
From: jvoisin
Date: Thu, 8 Mar 2018 14:08:44 +0100
Subject: Minor code simplification

---
 src/sp_utils.c | 16 +++++++---------
 1 file changed, 7 insertions(+), 9 deletions(-)

(limited to 'src/sp_utils.c')

diff --git a/src/sp_utils.c b/src/sp_utils.c
index bd7c9cd..8129f6b 100644
--- a/src/sp_utils.c
+++ b/src/sp_utils.c
@@ -312,15 +312,13 @@ int hook_function(const char* original_name, HashTable* hook_table,
 
   if ((func = zend_hash_str_find_ptr(CG(function_table),
                                      VAR_AND_LEN(original_name)))) {
-    if (func->handler == new_function) {
-      /* Success !*/
-    } else if (zend_hash_str_add_new_ptr((hook_table),
-                                         VAR_AND_LEN(original_name),
-                                         func->handler) == NULL) {
-      sp_log_err("function_pointer_saving",
-                 "Could not save function pointer for %s", original_name);
-      return FAILURE;
-    } else {
+    if (func->handler != new_function) {
+      if (zend_hash_str_add_new_ptr((hook_table), VAR_AND_LEN(original_name),
+                                    func->handler) == NULL) {
+        sp_log_err("function_pointer_saving",
+                   "Could not save function pointer for %s", original_name);
+        return FAILURE;
+      }
       func->handler = new_function;
     }
   }
-- 
cgit v1.3