From 040a5c222aa79dd25fcdf284b27109983e7578af Mon Sep 17 00:00:00 2001
From: jvoisin
Date: Mon, 30 Oct 2017 17:13:35 +0100
Subject: Fix a silly TOCTOU to make coverity happy

---
 src/sp_utils.c | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

(limited to 'src/sp_utils.c')

diff --git a/src/sp_utils.c b/src/sp_utils.c
index 1ba0fe7..1435f3f 100644
--- a/src/sp_utils.c
+++ b/src/sp_utils.c
@@ -86,11 +86,9 @@ static int construct_filename(char* filename, const char* folder) {
   struct timeval tval;
   struct stat st = {0};
 
-  if (-1 == stat(folder, &st)) {
-    if (0 != mkdir(folder, 0700)) {
-      sp_log_err("request_logging", "Unable to create the folder '%s'.",
-        folder);
-    }
+  if (0 > mkdir(folder, 0700) && errno != EEXIST) {
+    sp_log_err("request_logging", "Unable to create the folder '%s'.",
+      folder);
   }
 
   memcpy(filename, folder, strlen(folder));
-- 
cgit v1.3