From aa550b9abadc109a2c89a7cd6dd047ac2a953027 Mon Sep 17 00:00:00 2001 From: jvoisin Date: Sat, 6 Oct 2018 16:15:00 +0000 Subject: Bump a bit the coverage * `setcookie` doesn't always return `true` anymore * clang-format * Cookies with invalid decryption are dropped, but the request isn't anymore * faulty unserialize are now dumpable--- src/sp_session.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) (limited to 'src/sp_session.c') diff --git a/src/sp_session.c b/src/sp_session.c index 0f1c0b8..73fda22 100644 --- a/src/sp_session.c +++ b/src/sp_session.c @@ -27,10 +27,11 @@ static ZEND_INI_MH((*old_OnUpdateSaveHandler)) = NULL; static int sp_hook_s_read(PS_READ_ARGS) { int r = old_s_read(mod_data, key, val, maxlifetime); - const sp_config_session* config_session = SNUFFLEUPAGUS_G(config).config_session; + const sp_config_session *config_session = + SNUFFLEUPAGUS_G(config).config_session; - if (r == SUCCESS && config_session->encrypt && - val != NULL && *val != NULL && ZSTR_LEN(*val)) { + if (r == SUCCESS && config_session->encrypt && val != NULL && *val != NULL && + ZSTR_LEN(*val)) { zend_string *orig_val = *val; zval val_zval; ZVAL_PSTRINGL(&val_zval, ZSTR_VAL(*val), ZSTR_LEN(*val)); @@ -40,7 +41,7 @@ static int sp_hook_s_read(PS_READ_ARGS) { if (config_session->simulation) { return ret; } else { - sp_terminate(); + zend_bailout(); } } -- cgit v1.3