From a1675cd79b0df2478026573b0fac52464ef3c1b7 Mon Sep 17 00:00:00 2001 From: xXx-caillou-xXx Date: Wed, 20 Dec 2017 16:08:18 +0100 Subject: Make `setcookie` return true We forgot to set a return value to the setcookie function, thus always returning false. Since very few frameworks/developers are checking the return value, it went unnoticed until we played with Magento, who effectively checks the return value.--- src/sp_cookie_encryption.c | 1 + 1 file changed, 1 insertion(+) (limited to 'src/sp_cookie_encryption.c') diff --git a/src/sp_cookie_encryption.c b/src/sp_cookie_encryption.c index 2d6c938..0e279ed 100644 --- a/src/sp_cookie_encryption.c +++ b/src/sp_cookie_encryption.c @@ -232,6 +232,7 @@ PHP_FUNCTION(sp_setcookie) { call_user_function(CG(function_table), NULL, &func_name, &ret_val, 7, params); func->handler = PHP_FN(sp_setcookie); + RETURN_TRUE; } int hook_cookies() { -- cgit v1.3