From 12b740bc7bb01ffe397cecc5b6fa25b136304911 Mon Sep 17 00:00:00 2001
From: Remi Collet
Date: Tue, 10 Jul 2018 12:01:12 +0200
Subject: Fix #183 (#185)

* relax test to pass with 7.3

* skip test with 7.3 as samesite is broken + add TODO
---
 src/sp_cookie_encryption.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

(limited to 'src/sp_cookie_encryption.c')

diff --git a/src/sp_cookie_encryption.c b/src/sp_cookie_encryption.c
index 72223ad..6cb1ff7 100644
--- a/src/sp_cookie_encryption.c
+++ b/src/sp_cookie_encryption.c
@@ -108,8 +108,9 @@ PHP_FUNCTION(sp_setcookie) {
     ZVAL_LONG(&params[6], httponly);
   }
 
-  /* param[3](path) is concatenated to path= and is not filtered, we can inject
-  the samesite parameter here */
+  /* param[3](path) is concatenated to path= and is not filtered in PHP < 7.3
+     we can inject the samesite parameter here
+     TODO find another solution with 7.3 */
   if (cookie_node && cookie_node->samesite) {
     if (!path) {
       path = zend_string_init("", 0, 0);
-- 
cgit v1.3