From 86dac0e21cb9547ce1544539bb0f2c2f73ca5f73 Mon Sep 17 00:00:00 2001 From: jvoisin Date: Fri, 1 Dec 2017 17:28:44 +0100 Subject: Fail sooner when not able to create the folder to dump --- src/sp_utils.c | 1 + src/tests/dump_request_invalid_folder.phpt | 1 - 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/src/sp_utils.c b/src/sp_utils.c index 73ad528..d4ca73d 100644 --- a/src/sp_utils.c +++ b/src/sp_utils.c @@ -88,6 +88,7 @@ static int construct_filename(char* filename, const char* folder) { if (0 > mkdir(folder, 0700) && errno != EEXIST) { sp_log_err("request_logging", "Unable to create the folder '%s'.", folder); + return -1; } memcpy(filename, folder, strlen(folder)); diff --git a/src/tests/dump_request_invalid_folder.phpt b/src/tests/dump_request_invalid_folder.phpt index f8e3b43..6d395d0 100644 --- a/src/tests/dump_request_invalid_folder.phpt +++ b/src/tests/dump_request_invalid_folder.phpt @@ -22,4 +22,3 @@ echo "2\n"; 1 [snuffleupagus][0.0.0.0][disabled_function][drop] The call to the function 'system' in %atests/dump_request_invalid_folder.php:3 has been disabled. [snuffleupagus][0.0.0.0][request_logging][error] Unable to create the folder '/root/NON_EXISTENT/FOLDER/PLEASE/'. -[snuffleupagus][0.0.0.0][request_logging][error] Unable to open /root/NON_EXISTENT/FOLDER/PLEASE/sp_dump_%a_0.0.0.0.dump -- cgit v1.3