Add format attribute to log function and adjust format specifiers

Annotate the common logging function sp_log_msgf() with the format
attribute so compilers can check the used format string and passed
arguments for discrepancies.

Adjust the lineno printing by using %zu and the type size_t
consistently.

1 files changed, 5 insertions, 0 deletions

diff --git a/src/sp_utils.h b/src/sp_utils.h
index 36caa52..1146db3 100644
--- a/src/sp_utils.h
+++ b/src/sp_utils.h
@@ -71,6 +71,11 @@ extern int sp_debug_stderr;
 #define GET_SUFFIX(x) (x == 1) ? "st" : ((x == 2) ? "nd" : "th")
 
 const char *get_ipaddr(void);
+#if defined __has_attribute
+#  if __has_attribute (__format__)
+     __attribute__((__format__(printf, 4, 5)))
+#  endif
+#endif
 void sp_log_msgf(char const* const restrict feature, int level, int type, char const* const restrict fmt, ...);
 int compute_hash(char const* const restrict filename, char *restrict file_hash);
 const zend_string *sp_zval_to_zend_string(const zval *);