summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorjvoisin2025-12-31 00:45:46 +0100
committerjvoisin2026-01-05 21:43:10 +0100
commit9278dc77bab2a219e770a1b31dd6797bc9070e37 (patch)
treef0f97d6d5bd8878997eafbe2a1493c3be5cc9e9d
parente586b7df4e575d7d5e017b4134bdac9b297b667b (diff)
Fix possible arbitrary code execution on misconfigured deployments
When `upload_validation` is enabled, and when VLD isn't installed, an attacker sending a multipart POST is able to get arbitrary PHP content executed. Reported-By: thomas-chauchefoin-tob
-rwxr-xr-xscripts/upload_validation.php1
-rwxr-xr-xscripts/upload_validation.py1
2 files changed, 2 insertions, 0 deletions
diff --git a/scripts/upload_validation.php b/scripts/upload_validation.php
index 6788d57..6480f20 100755
--- a/scripts/upload_validation.php
+++ b/scripts/upload_validation.php
@@ -16,6 +16,7 @@ function check($filename) {
16 "-d", "vld.col_sep=@", 16 "-d", "vld.col_sep=@",
17 "-d", "log_errors=0", 17 "-d", "log_errors=0",
18 "-d", "error_log=/dev/null", 18 "-d", "error_log=/dev/null",
19 "-l",
19 escapeshellarg($filename), 20 escapeshellarg($filename),
20 '2>&1', 21 '2>&1',
21 ]; 22 ];
diff --git a/scripts/upload_validation.py b/scripts/upload_validation.py
index 1152804..e7ba195 100755
--- a/scripts/upload_validation.py
+++ b/scripts/upload_validation.py
@@ -15,6 +15,7 @@ def check(filename):
15 "-d", "vld.col_sep=@", 15 "-d", "vld.col_sep=@",
16 "-d", "log_errors=0", 16 "-d", "log_errors=0",
17 "-d", "error_log=/dev/null", 17 "-d", "error_log=/dev/null",
18 "-l",
18 filename], 19 filename],
19 stderr=subprocess.STDOUT) 20 stderr=subprocess.STDOUT)
20 except subprocess.CalledProcessError as e: 21 except subprocess.CalledProcessError as e: