snuffleupagus/src/sp_upload_validation.c, branch master

Fix an spprintf undefined behaviour

2026-04-24T10:14:01Z

`getenv("REMOTE_ADDR")` can return NULL, and it is passed directly to `spprintf`. While `spprintf` might handle `NULL` gracefully, it's not always the case.

Cast format argument to expected type

2025-06-25T17:38:39Z

Please GCC conversion warning: src/sp_upload_validation.c: In function 'sp_rfc1867_callback': src/sp_utils.h:61:53: warning: format '%lld' expects argument of type 'long long int', but argument 7 has type 'zend_long' {aka 'long int'} [-Wformat=] 61 | if (sp_debug_stderr > 0) dprintf(sp_debug_stderr, "[snuffleupagus][DEBUG] %s(): " fmt "\n", __FUNCTION__, ##__VA_ARGS__); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ src/sp_upload_validation.c:48:7: note: in expansion of macro 'sp_log_debug' 48 | sp_log_debug("Filename: %s\nTmpname: %s\nSize: %zd\nError: %lld\nScript: %s", | ^~~~~~~~~~~~

Declare file local variables and functions static

2024-06-06T14:27:31Z

Avoid missing prototype warnings by declaring variables and functions that are only used in a single file static.

removed confusung newlines for better reading/searching

2021-12-20T16:58:23Z

config is stack allocated now + some code improvements (see details)

2021-09-23T10:23:40Z

* for easier memory manegement, the entire sp_config struct was merged into snuffleupagus_globals and allocated on stack where possible * SNUFFLEUPAGUS_G() can be written as SPG(), which is faster to type and easier to read * execution_depth is re-initialized to 0 for each request * function calls with inline string and length parameters consistently use ZEND_STRL instead of sizeof()-1 * execution is actually hooked if recursion protection is enabled * some line breaks were removed to make the code more readable

fixed compiler warning

2021-08-07T20:31:55Z

Add some checks to prevent recursion upon config reloading

2021-05-09T20:32:46Z

Allow empty configuration (#342)

2020-08-12T08:48:59Z

This commit allows php to run (with a warning) if there is no specified snuffleupagus configuration, instead of refusing to start.

refactoring sp_log_* (#340)

2020-07-22T07:28:42Z

Co-authored-by: Giovanni Dante Grazioli

%s/nbs-system/jvoisin

2020-03-04T18:30:42Z

Since I'm the only one to maintain Snuffleupagus, let's adjust the links and contact addresses of my fork, to point to well… my fork.