fortify-headers/include, branch 2.3.2

Disable snprintf/sprintf hardening for now

2024-10-09T23:51:34Z

Fix usage of strnlen

2024-10-03T22:16:50Z

As with previous commit, some strnlen calls where introduced in 22a8094, but not reverted. As strnlen isn't part of C standard, this was breaking C builds.

Use const fd_set for FD_ISSET

2024-10-03T18:22:48Z

This fixes invalid conversion errors when the fd_set is defined as const. fixes https://github.com/jvoisin/fortify-headers/issues/66

Work around a gcc warning

2024-09-06T11:38:22Z

It seems that annotating sprintf with `write` makes gcc unhappy, as its analyser is unable to understand that we're checking if `__b != -1` before calling `__orig_snprintf`, so let's comment this annotation for now.

Revert d2594298b89d0fb8989cae3ebc8900e77b6aa478

2024-09-02T14:11:06Z

As reported on irc: ``` 17:51 jvoisin, fortify-headers seems to be broken (on Alpine at least) 17:52 Repeating the message from over-there: 17:52 /usr/include/fortify/string.h: In function 'strncat': 17:52 /usr/include/fortify/string.h:297:36: error: implicit declaration of function 'strnlen'; did you mean 'strlen'? [-Wimplicit-function-declaration] 17:52 This is with a simple file that includes string.h and call strncat, built with c99 -O1 f.c ```

Fix access annotation for stpncpy/strncpy

2024-07-10T14:46:15Z

The dsize parameter is the length of the dst, not the length of the src. Reported-by: ncopa

Fix access annotations to snprintf/sprintf

2024-07-10T14:03:42Z

In the same spirit as the previous commit. Reported-by: ncopa

Fix `access` annotations for vsnprintf/vsprintf

2024-07-10T13:49:00Z

This fix the following issue: ``` In file included from exec-cmd.c:9: In function 'vsnprintf', inlined from 'report.constprop' at subcmd-util.h:13:2: /usr/include/fortify/stdio.h:162:16: error: 'msg' may be used uninitialized [-Werror=maybe-uninitialized] 162 | return __orig_vsnprintf(__s, __n, __f, __v); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ In file included from /usr/include/fortify/strings.h:23, from /usr/include/string.h:59, from /usr/include/fortify/string.h:23, from /home/ncopa/aports/main/linux-lts/src/linux-6.6/tools/include/linux/string.h:6, from exec-cmd.c:3: /usr/include/fortify/stdio.h: In function 'report.constprop': /usr/include/fortify/stdio.h:152:1: note: in a call to '__orig_vsnprintf' declared with attribute 'access (read_write, 1, 2)' here 152 | _FORTIFY_FN(vsnprintf) int vsnprintf(char * _FORTIFY_POS0 __s, size_t __n, | ^~~~~~~~~~~ In file included from exec-cmd.c:10: subcmd-util.h:12:14: note: 'msg' declared here 12 | char msg[1024]; | ^~~ cc1: all warnings being treated as errors make[5]: *** [/home/ncopa/aports/main/linux-lts/src/linux-6.6/tools/build/Makefile.build:98: /home/ncopa/aports/main/linux-lts/src/build-virt.x86_64/tools/objtool/libsubcmd/exec-cmd.o] Error 1 make[4]: *** [Makefile:80: /home/ncopa/aports/main/linux-lts/src/build-virt.x86_64/tools/objtool/libsubcmd/libsubcmd-in.o] Error 2 make[3]: *** [Makefile:78: /home/ncopa/aports/main/linux-lts/src/build-virt.x86_64/tools/objtool/libsubcmd/libsubcmd.a] Error 2 make[2]: *** [Makefile:73: objtool] Error 2 make[1]: *** [/home/ncopa/aports/main/linux-lts/src/linux-6.6/Makefile:1362: tools/objtool] Error 2 make: *** [/home/ncopa/aports/main/linux-lts/src/linux-6.6/Makefile:234: __sub-make] Error 2 ``` Reported-by: ncopa

prefix special defines with FORTIFY_

2024-07-10T13:20:23Z

just in case, and because 'PEDANTIC_CHECKS' is a really generic name

Fix some pointer-arithmetic warnings

2024-06-15T13:46:35Z

This should fix the second part of #59