fortify-headers/include, branch 1.0

Don't use extension in C++ code

2018-07-24T10:00:30Z

A few important notes: * __extension__ is a GNU C "alternate" keyword, not a C++ keyword.[1] * __extension__ is designed to work on "expressions"; it does work on #include_next in C mode, but it has no effect in C++ mode; the warning will still appear, if enabled, even with __extension__ preceding #include_next. This is because #include_next is not considered an expression in C++, so the compiler attaches __extension__ to the first expression of the header. All of this leads us to a build failure while building at least all Mozilla software. Moz has an alternate -isystem dir searched before /usr/include that overrides some headers, including . The first statement in each of these headers is a #pragma, and since __extension__ is looking for an expression, and #pragma is a "null" expression, we end up with the following error: dist/system_wrappers/features.h:1:9: error: '#pragma' is not allowed here Since __extension__ has no effect on #include_next in C++ mode anyway, and since it can cause breakage, this commit omits __extension__ in C++ mode. [1]: https://gcc.gnu.org/onlinedocs/gcc-6.4.0/gcc/Alternate-Keywords.html

Don't trap if an encoding error occurs in wcrtomb()

2017-08-22T10:38:36Z

The POSIX definition of wcrtomb (http://pubs.opengroup.org/onlinepubs/9699919799/functions/wcrtomb.html) states: "When wc is not a valid wide character, an encoding error shall occur. In this case, the function shall store the value of the macro [EILSEQ] in errno and shall return (size_t)-1; the conversion state shall be undefined." The fortify-headers implementation of wcrtomb interprets the result -1 as 18446744073709551615 bytes. Since this is the highest 64-bit number possible, it is pretty safe to say this will always be larger than any buffer provided to wcrtomb. Therefore, it traps. Fixes bug https://bugs.alpinelinux.org/issues/7681. Patch by A. Wilcox

Bump copyright year

2016-09-10T11:54:17Z

Only include limits.h when actually used

2016-07-14T15:09:13Z

The __extension__ seems to trigger a bug in gcc when there are no identifier specified afterwards. Testcase: echo "#include " > try.c && cc -O0 -c try.c try.c:2:0: error: expected identifier or '(' at end of input With -O2 it does not happen. We work around this by only pulling in limits.h when we actually need the PATH_MAX. Signed-off-by: Natanael Copa

Only crash on overflow for realpath()

2015-07-16T10:45:19Z

Fix stpncpy() check

2015-07-15T16:02:27Z

Do not crash unless the overflow would happen.

Fix confstr() check

2015-07-15T15:05:52Z

Do not crash unless the overflow would actually happen.

Fix wcrtomb() check

2015-07-15T14:55:56Z

This was breaking valid code, example: char c; wcrtomb(&c, L'0', st);

Add extension mark to include_next to silence -pedantic

2015-06-25T09:18:26Z

Signed-off-by: Steven Barth

unistd: fix signed / unsigned comparison in getgroups

2015-06-22T18:05:54Z