fortify-headers, branch experimental

Add a missing FORTIFY_PEDANTIC_CHECKS

2025-10-28T22:18:21Z

Fixing the following issue: ``` In file included from xstrndup.c:34: /OpenWrt/aarch64/staging_dir/toolchain-aarch64_cortex-a53_gcc-14.3.0_musl/include/fortify/string.h: In function 'mempcpy': /OpenWrt/aarch64/staging_dir/toolchain-aarch64_cortex-a53_gcc-14.3.0_musl/include/fortify/string.h:340:13: error: 'nonnull' argument '__d' compared to NULL [-Werror=nonnull-compare] 340 | if (!__d || !__s) | ^~~~ /OpenWrt/aarch64/staging_dir/toolchain-aarch64_cortex-a53_gcc-14.3.0_musl/include/fortify/string.h:340:21: error: 'nonnull' argument '__s' compared to NULL [-Werror=nonnull-compare] 340 | if (!__d || !__s) | ^~~~ cc1: all warnings being treated as errors make[5]: *** [Makefile:511: xstrndup.o] Error 1 ``` Reported in https://github.com/openwrt/openwrt/pull/20552

Fix possible cast-mismatch spotted by `-Werror=cast-qual`

2025-10-28T22:16:05Z

Use C90-compliant comments

2025-10-28T22:13:42Z

Fix the CI on clang

2025-10-28T20:54:31Z

Apparently, clang doesn't like the `putwchar` function for no good reason. Replacing it with `printf` fixes a NULL-ptr deref, so let's do that, as we don't really care about the content of the buffer anyway, only that it's not optimized away.

Remove superfluous defines in the testsuite

2025-10-28T19:27:43Z

Add GCC14 to the CI

2025-10-28T19:20:21Z

fortify-headers: Remove __fh_has_builtin()

2025-10-28T19:09:50Z

GCC complains about the `defined` usage here. Just call `__has_builtin` directly. This fixes the following compile error when compiling strace: ``` In file included from /home/hauke/openwrt/openwrt/staging_dir/toolchain-aarch64_generic_gcc-14.3.0_musl/include/fortify/stdlib.h:27, from number_set.c:14: /home/hauke/openwrt/openwrt/staging_dir/toolchain-aarch64_generic_gcc-14.3.0_musl/include/fortify/fortify-headers.h:26:30: error: this use of "defined" may not be portable [-Werror=expansion-to-defined] 26 | #define __fh_has_builtin(x) (__has_builtin(x) || defined(x)) | ^~~~~~~~~~~~~ /home/hauke/openwrt/openwrt/staging_dir/toolchain-aarch64_generic_gcc-14.3.0_musl/include/fortify/fortify-headers.h:28:7: note: in expansion of macro '__fh_has_builtin' 28 | #if ! __fh_has_builtin(__builtin_trap) | ^~~~~~~~~~~~~~~~ /home/hauke/openwrt/openwrt/staging_dir/toolchain-aarch64_generic_gcc-14.3.0_musl/include/fortify/fortify-headers.h:26:30: error: this use of "defined" may not be portable [-Werror=expansion-to-defined] 26 | #define __fh_has_builtin(x) (__has_builtin(x) || defined(x)) | ^~~~~~~~~~~~~ /home/hauke/openwrt/openwrt/staging_dir/toolchain-aarch64_generic_gcc-14.3.0_musl/include/fortify/fortify-headers.h:73:29: note: in expansion of macro '__fh_has_builtin' 73 | #if _FORTIFY_SOURCE > 2 && __fh_has_builtin (__builtin_dynamic_object_size) | ^~~~~~~~~~~~~~~~ /home/hauke/openwrt/openwrt/staging_dir/toolchain-aarch64_generic_gcc-14.3.0_musl/include/fortify/fortify-headers.h:26:30: error: this use of "defined" may not be portable [-Werror=expansion-to-defined] 26 | #define __fh_has_builtin(x) (__has_builtin(x) || defined(x)) | ^~~~~~~~~~~~~ /home/hauke/openwrt/openwrt/staging_dir/toolchain-aarch64_generic_gcc-14.3.0_musl/include/fortify/fortify-headers.h:158:5: note: in expansion of macro '__fh_has_builtin' 158 | #if __fh_has_builtin (__builtin_mul_overflow_p) | ^~~~~~~~~~~~~~~~ cc1: all warnings being treated as errors ``` Signed-off-by: Hauke Mehrtens

Check if FORTIFY_USE_NATIVE_CHK is defined

2025-10-28T17:12:50Z

The previews code tried to get the value defined for FORTIFY_USE_NATIVE_CHK and this resulted in some build errors like this: ``` /include/fortify/stdio.h: In function 'vsnprintf': /include/fortify/stdio.h:155:49: error: "FORTIFY_USE_NATIVE_CHK" is not defined, evaluates to 0 [-Werror=undef] 155 | #if __has_builtin(__builtin___vsnprintf_chk) && FORTIFY_USE_NATIVE_CHK | ^~~~~~~~~~~~~~~~~~~~~~ ``` Check if it is defined instead. Signed-off-by: Hauke Mehrtens

poll: Check if _REDIR_TIME64 is defined

2025-10-28T17:12:42Z

Treat _REDIR_TIME64 being undefined like being set to 0. This fixes the following compile error in strace: ``` In file included from pathtrace.c:12: /include/fortify/poll.h:46:30: error: "_REDIR_TIME64" is not defined, evaluates to 0 [-Werror=undef] 46 | #if defined(_GNU_SOURCE) && !_REDIR_TIME64 | ^~~~~~~~~~~~~ cc1: all warnings being treated as errors ``` Signed-off-by: Hauke Mehrtens

Allow the CI to fail on clang for now

2025-10-28T17:10:57Z

We know clang isn't working great for now, and we still need the CI to fix bugs.